-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maximizing window on Windows positions it slightly off screen #1202
Comments
I think this is electron/electron#8728 whose fix just landed: electron/electron#9167 |
sigh, 10 seconds after I submitted electron/electron#9184 😢 |
https://github.com/electron/electron/releases/tag/v1.6.7 is out which should have the fix. |
Testing this with 1.6.7 looks better when maximized: Here's the same console output that @niik used to troubleshoot - I gather the And |
Hi, I got the same problem with my windows 10 file explorer. I'm not familiar to programming, can anyone help me to solve this step by step? its a minor issue but it really bothering me. |
This is out title bar when window is not maximized
Make note of the margin between the top of the app icon and the window edge
This is the same title bar when the app is maximized
Calling
getPosition
on theBrowserWindow
instance seems to indicate that we're positioned 8px to the left and 8px above from the screen top left edgeThe size is also wrong
On my monitor the size of a maximized window should be 2560x1400 (full width and -40px to account for the Windows task bar) but it seems to be 16px too large both on the x and y axis.
There's a 16px magic number in the electron code base that I suspect might have something to do with it but it could just be a coincidence as well.
cc @kevinsawicki, this seems to be a problem with electron, I'm gonna see if I can make a small reproduction repository and then open an issue on Electron
The text was updated successfully, but these errors were encountered: