Show file status tooltip on keyboard navigation #17192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tidy-dev
approved these changes
Aug 8, 2023
|
I think this change broke how you can select files to commit using spacebar, because now when pressing spacebar it checks and immediately unchecks the checkbox. |
koenpunt
reviewed
Aug 10, 2023
| } | ||
|
|
||
| private onRowKeyUp = (e: React.KeyboardEvent<HTMLDivElement>) => { | ||
| this.props.onRowKeyDown(this.props.rowIndex, e) |
There was a problem hiding this comment.
Shouldn't this be calling this.props.onRowKeyUp?
There was a problem hiding this comment.
Yep, you're right 😭 Nice catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref. https://github.com/github/accessibility-audits/issues/4938
Description
In #17144 we added the file status to the aria label of our file list items. However that won't be of any use for keyboard-only users that don't use screen readers. Inspired by the work done in #16487, this PR attempts to improve the experience for those users by automatically showing a tooltip over that icon when those list entries get the focus via keyboard interaction.
Compared to #16487, where the tooltip is shown no matter how the changes list header obtained the focus, in this case we will only do that for keyboard interaction because otherwise it gets excessively noisy when the user clicks on these files.
In order to detect when a row gets focused via keyboard, I had to use some heuristics and detect some key events before and after being focused. It's not absolutely perfect, I'm sure of that, but should be enough for our purposes.
Screenshots
Screen.Recording.2023-08-08.at.10.02.22.mov
Release notes
Notes: [Fixed] Improve readability of file statuses for keyboard-only users