Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open the changed file header tool tip on checkbox focus #16487

Merged

Conversation

tidy-dev
Copy link
Contributor

@tidy-dev tidy-dev commented Apr 8, 2023

xref: https://github.com/github/accessibility-audits/issues/3275

Description

Building on #16457 which made the changes list header tooltip screen reader announced on checkbox focus, this PR opens the tooltip on checkbox focus so that it is accessible by keyboard users who do not use screen readers.

Screenshots

CleanShot.2023-04-07.at.20.21.56.mp4

Release notes

Notes: [Improved] Changes list header tooltip is keyboard accessible.

@tidy-dev tidy-dev merged commit d83ca1b into development Apr 12, 2023
7 checks passed
@tidy-dev tidy-dev deleted the open-changed-list-heading-tooltip-on-checkbox-focus branch April 12, 2023 15:28
berend1connect pushed a commit to berend1connect/desktop that referenced this pull request May 1, 2023
…ng-tooltip-on-checkbox-focus

Open the changed file header tool tip on checkbox focus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants