Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an upstream to forked repositories #2364

Closed
j-f1 opened this issue Jul 31, 2017 · 5 comments
Closed

Add an upstream to forked repositories #2364

j-f1 opened this issue Jul 31, 2017 · 5 comments
Assignees
Milestone

Comments

@j-f1
Copy link
Contributor

j-f1 commented Jul 31, 2017

Description

Currently, cloning a forked repository adds an origin remote linking to the fork on GitHub. However, there is no way to fetch changes from the parent, because no remote is added for the parent.

Version

GitHub Desktop version: 0.7.0

OS version: macOS 10.12.3 (16D32)

Steps to Reproduce

  1. Fork a repo on GitHub
  2. Clone the fork with GitHub Desktop
  3. Run git remote on the command line

Expected behavior: Two remotes are present, with origin linking to the fork and upstream or username-of-parent-repo linking to the parent repo

Actual behavior: Only the origin remote is present

Reproduces how often: Always

@iAmWillShepherd
Copy link
Contributor

Thanks for creating this issue. We actually already have this on our roadmap for v1.1, but didn't have an issue for it yet.

@joshaber
Copy link
Contributor

joshaber commented Sep 7, 2017

Scope for 1.1:

  • Add an upstream remote to forked repositories
  • Include in the periodic fetch

Designs TBD

@joshaber
Copy link
Contributor

joshaber commented Sep 7, 2017

Is this something we'd do silently and automagically, or would we ask the user, similar to LFS setup?

screen shot 2017-09-05 at 2 54 32 pm

@joshaber joshaber added this to the 1.1 milestone Sep 7, 2017
@joshaber joshaber added the design-input-needed Issues that require design input from the core team before the work can be started label Sep 7, 2017
@j-f1
Copy link
Contributor Author

j-f1 commented Sep 7, 2017

I think it should be automatic since they don’t have to use the remote if they don’t want to, and it shouldn’t cause any issues, unlike LFS which requires that you pay for storage space if you use too much.

@joshaber joshaber changed the title Add a remote linking to the parent of a forked repo when cloning Add a remote linking to the parent of a forked repo Sep 7, 2017
@joshaber
Copy link
Contributor

joshaber commented Sep 7, 2017

I'm leaning that way too. The only case that would cause problems is if they already have an upstream remote configured to something else. I gotta think those cases would be vanishingly rare tho.

@joshaber joshaber changed the title Add a remote linking to the parent of a forked repo Add an upstream to forked repositories Sep 7, 2017
@shiftkey shiftkey assigned shiftkey and unassigned shiftkey Sep 19, 2017
@joshaber joshaber self-assigned this Sep 26, 2017
@joshaber joshaber removed the design-input-needed Issues that require design input from the core team before the work can be started label Oct 31, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants