-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub wiki repos not detected correctly, asks user to publish again #3839
Comments
@brcontainer apologies for the delay in replying
Can you clarify how this is being cloned? Using the regular clone URL? Or doing it via the command line and adding the folder to the repository? |
@shiftkey clicking in "Clone in Desktop" button in any wiki repository, example:
Edited: Note in non-wiki reposirorys the console not show errors, but repositories from github-wiki show 404 error (HTTP), see image:
|
It looks like we’re trying to get information from the API for the wiki, but GitHub’s API doesn’t support wikis. Maybe we should strip of the |
@j-f1 exactly, this will probably cause problems with non-github repositories too. |
@brcontainer thanks for the extra details. I was able to reproduce this. I think there's two different problems here:
|
I guess this bug is confirmed but I can confirm I'm seeing this bug too. |
Any word on this? I just ran into the same thing. Cheers. |
I just ran into this as well. Created a new wiki on GitHub.com, cloned it to Desktop, and added a file. When attempting to push get the |
I probably have the same issue: I can't fetch from any of my GitHub Wiki repositories with GitHub Desktop v1.2.3 for Mac OSX High Sierra, nothing happens when I click on button Fetch origin. I am using SSH authentication and remote origin URL looks like Note that it worked well with previous version of the GitHub Desktop app, and fetching/pulling/pushing works well from |
Any news on when this will be fixed? |
This is still a persistent issue for me; only solution is periodically deleting local repo and re-cloning (clearly not a sustainable solution). |
same as @olange |
The same goes for the GitHub Desktop 1.3.2 version. |
I can push and pull under terminal meaning this is not a core issue. |
I can reproduce this issue in Github Desktop 1.3.3 for Macos. Command line |
still there with 1.3.4 . . . . . clicking on the 'Fetch origin' wheel still does not trigger anything from the GUI |
This only seems to be happening with wikis. The repos work just fine. Still happening as of 8/31. On Version 1.3.4 for Windows. |
Still happening for me too, version 1.3.4 for windows. |
Happens on Version 1.4.0 for macOS too. (SSH + 2-factor auth) The GitHub Desktop gives me a message below but nothing happens when pushed. Though the local repo seems to be up to date. $ git pull origin
Already up to date.
$
$ # Env info
$ git --version
git version 2.17.0
$
$ sw_vers
ProductName: Mac OS X
ProductVersion: 10.13.6
BuildVersion: 17G65
Add comment 2018/09/14: Looking at the log, it seems that it's trying to get "issues" from Wiki's repo and since then stops working to fetch/push. Also this seems to happen after I turned the Two-factor authentication enabled. $ git push origin master
remote: Invalid username or password.
fatal: Authentication failed for 'https://github.com/Qithub-BOT/Qithub-ORG.wiki.git/' Logs from [Help]-[Show Logs in Finder]Log after cloning a wiki's repo by URL and do nothing else2018-09-13T15:48:53.191Z - info: [ui] [AppStore] loading 21 repositories from store
2018-09-13T15:48:53.192Z - info: [ui] [AppStore] found account: KEINOS (KEINOS)
2018-09-13T15:48:54.012Z - info: [ui] launching: 1.4.0 (Mac OS 10.13.6)
2018-09-13T15:48:54.013Z - info: [ui] execPath: '/Applications/GitHub Desktop.app/Contents/Frameworks/GitHub Desktop Helper.app/Contents/MacOS/GitHub Desktop Helper'
2018-09-13T15:49:10.751Z - warn: [ui] fetchRepository: 'Qithub-BOT/Qithub-ORG.wiki' returned a 404
2018-09-13T15:49:10.753Z - info: [ui] [AppStore.getAccountForRemoteURL] account found for remote: https://github.com/Qithub-BOT/Qithub-ORG.wiki.git - KEINOS (has token)
2018-09-13T15:49:13.137Z - info: [ui] Executing clone: git -c credential.helper= clone --recursive --progress -- https://github.com/Qithub-BOT/Qithub-ORG.wiki.git /Volumes/Macintosh_SD/Git/GitHub/Qithub/Qithub-ORG.wiki (took 2.380s)
2018-09-13T15:49:13.149Z - info: [ui] [AppStore] adding repository at /Volumes/Macintosh_SD/Git/GitHub/Qithub/Qithub-ORG.wiki to store
2018-09-13T15:49:13.811Z - warn: [ui] fetchRepository: 'Qithub-BOT/Qithub-ORG.wiki' returned a 404
2018-09-13T15:49:13.811Z - info: [ui] [AppStore.withAuthenticatingUser] account found for repository: Qithub-ORG.wiki - KEINOS (has token) Log after pushed the "Fetch origin" button. (No commit made)2018-09-13T15:50:26.043Z - info: [ui] [AppStore] loading 22 repositories from store
2018-09-13T15:50:26.044Z - info: [ui] [AppStore] found account: KEINOS (KEINOS)
2018-09-13T15:50:26.637Z - info: [ui] launching: 1.4.0 (Mac OS 10.13.6)
2018-09-13T15:50:26.639Z - info: [ui] execPath: '/Applications/GitHub Desktop.app/Contents/Frameworks/GitHub Desktop Helper.app/Contents/MacOS/GitHub Desktop Helper'
2018-09-13T15:50:28.427Z - warn: [ui] fetchRepository: 'Qithub-BOT/Qithub-ORG.wiki' returned a 404
2018-09-13T15:50:28.427Z - info: [ui] [AppStore.withAuthenticatingUser] account found for repository: Qithub-ORG.wiki - KEINOS (has token)
2018-09-13T15:50:28.789Z - warn: [ui] Unable to fetch issues for Qithub-BOT/Qithub-ORG.wiki
Error: Cannot get issues for a repository that hasn't been inserted into the database!
at Object.n [as fatalError] (/webpack:/external "path":1:1)
at t.IssuesStore.getLatestUpdatedAt (/webpack:/app/src/lib/stores/issues-store.ts:29:14)
at t.IssuesStore.refreshIssues (/webpack:/app/src/lib/stores/issues-store.ts:66:5)
at ye._refreshIssues (/webpack:/app/src/lib/stores/app-store.ts:1305:6)
at withPushPull (/webpack:/app/src/lib/stores/app-store.ts:3029:18)
at <anonymous>
2018-09-13T15:50:29.023Z - warn: [ui] fetchRepository: 'Qithub-BOT/Qithub-ORG.wiki' returned a 404
2018-09-13T15:50:29.220Z - warn: [ui] fetchRepository: 'Qithub-BOT/Qithub-ORG.wiki' returned a 404
2018-09-13T15:50:30.302Z - warn: [ui] fetchRepository: 'Qithub-BOT/Qithub-ORG.wiki' returned a 404
2018-09-13T15:50:30.302Z - info: [ui] [AppStore.withAuthenticatingUser] account found for repository: Qithub-ORG.wiki - KEINOS (has token)
2018-09-13T15:50:31.024Z - warn: [ui] Unable to fetch issues for Qithub-BOT/Qithub-ORG.wiki
Error: Cannot get issues for a repository that hasn't been inserted into the database!
at Object.n [as fatalError] (/webpack:/external "path":1:1)
at t.IssuesStore.getLatestUpdatedAt (/webpack:/app/src/lib/stores/issues-store.ts:29:14)
at t.IssuesStore.refreshIssues (/webpack:/app/src/lib/stores/issues-store.ts:66:5)
at ye._refreshIssues (/webpack:/app/src/lib/stores/app-store.ts:1305:6)
at withPushPull (/webpack:/app/src/lib/stores/app-store.ts:3029:18)
at <anonymous>
2018-09-13T15:50:31.257Z - warn: [ui] fetchRepository: 'Qithub-BOT/Qithub-ORG.wiki' returned a 404
2018-09-13T15:50:31.458Z - warn: [ui] fetchRepository: 'Qithub-BOT/Qithub-ORG.wiki' returned a 404 Log after some commit and try to "Push Origin"2018-09-13T15:59:22.328Z - info: [ui] [AppStore] loading 22 repositories from store
2018-09-13T15:59:22.329Z - info: [ui] [AppStore] found account: KEINOS (KEINOS)
2018-09-13T15:59:23.047Z - info: [ui] launching: 1.4.0 (Mac OS 10.13.6)
2018-09-13T15:59:23.048Z - info: [ui] execPath: '/Applications/GitHub Desktop.app/Contents/Frameworks/GitHub Desktop Helper.app/Contents/MacOS/GitHub Desktop Helper'
2018-09-13T15:59:46.829Z - warn: [ui] fetchRepository: 'Qithub-BOT/Qithub-ORG.wiki' returned a 404
2018-09-13T15:59:46.830Z - info: [ui] [AppStore.withAuthenticatingUser] account found for repository: Qithub-ORG.wiki - KEINOS (has token)
2018-09-13T16:01:35.447Z - info: [ui] Background fetch for 22 repositories took 13.072sec
2018-09-13T16:01:48.530Z - warn: [ui] fetchRepository: 'Qithub-BOT/Qithub-ORG.wiki' returned a 404
2018-09-13T16:01:48.531Z - info: [ui] [AppStore.withAuthenticatingUser] account found for repository: Qithub-ORG.wiki - KEINOS (has token) |
For those who use SSH and 2-factor authentication, the workaround below worked for me. Though, it uses
|
Thanks for the instructions @KEINOS
You can use Menu / Repository / Open in Terminal to save you having to cd to the repo path before doing your |
Same issue as @Rauschii and others above for me in GitHub Desktop v2.9.3 (x64) "Can't find repository matching {myorg}/{myrepo}.wiki.git" And yet I can clone using command line git using the same. |
sad that this has been in backlog for 4 years |
Fails for me when trying to clone an enterprise GitHub wiki too. I was shocked to find that this has been a known issue for 4 years. If I was able to upload (or drag-and-drop) images to the web UI wiki, I wouldn't need to clone the wiki in the first place. I'm shocked that adding images to a wiki is so hard. It's like GitHub doesn't want us to use their wiki function. I can upload images easily to this comment, but not a wiki editor. |
Any chance this bug could get upgraded to a higher priority level? It is one of the top 10 most commented on open issues in this repo. And the wiki feature is difficult to use without this fix. @shiftkey @tierninho @billygriffin |
Does it really matter considering we're all about to get murdered in state-funded holocaust? |
Yes; we may as well go out swinging. +1 to issue importance. |
It's an important function for us, hope can fix it ASAP. |
+1 to fix this one. Can anyone comment on the current work around? If we clone using the command line can we then still use gitdesktop to fetch changes? |
I got this same issue, my solution was to log out/log in my GitHub user, and the problem was solved, not sure if may work for everybody. |
Gah, just encountered this myself :( I can't clone the wiki using Github Desktop, and if I clone it with the command line, I can't push any changes back either. Tried with all sorts of combinations of /wiki .wiki etc. |
More research is needed, but in my environment, a Steps I tookThis is the target example repo: https://github.com/KEINOS/wiki-test/wiki
My guessAs you can see, apart from cloning the wiki repository with the My guess is:
GITHUB_TOKENThis is the log of a successful attempt (the Full log of the aboveinstall.ts:28 [AppStore.withAuthenticatingUser] account found for repository: wiki-test.wiki - KEINOS (has token)
install.ts:28 Executing push: git -c credential.helper= push origin master:master --progress (took 2.374s)
http.ts:152 GET https://api.github.com/repos/KEINOS/wiki-test.wiki/branches/master/push_control 404
Mt @ http.ts:152
request @ api.ts:1401
fetchPushControl @ api.ts:1319
refreshBranchProtectionState @ app-store.ts:1099
f.performFailableOperation.retryAction @ app-store.ts:4189
await in f.performFailableOperation.retryAction (async)
processTicksAndRejections @ node:internal/process/task_queues:96
await in processTicksAndRejections (async)
performFailableOperation @ git-store.ts:912
(anonymous) @ app-store.ts:4135
withPushPullFetch @ app-store.ts:4253
performPush @ app-store.ts:4049
(anonymous) @ app-store.ts:4029
withAuthenticatingUser @ app-store.ts:5703
_push @ app-store.ts:4028
push @ dispatcher.ts:689
push @ push-pull-button.tsx:302
onClick @ button.tsx:144
onClick @ button.tsx:156
l @ react-dom.production.min.js:14
f @ react-dom.production.min.js:15
(anonymous) @ react-dom.production.min.js:15
R @ react-dom.production.min.js:17
A @ react-dom.production.min.js:18
_ @ react-dom.production.min.js:18
M @ react-dom.production.min.js:21
xn @ react-dom.production.min.js:84
Ta @ react-dom.production.min.js:250
Le @ react-dom.production.min.js:39
An @ react-dom.production.min.js:86
(anonymous) @ react-dom.production.min.js:251
t.unstable_runWithPriority @ scheduler.production.min.js:18
Da @ react-dom.production.min.js:251
Dn @ react-dom.production.min.js:85
install.ts:28 [fetchPushControl] unable to check if branch is potentially pushable
Error: Not Found
at Ot (/webpack:/[name]/app/src/lib/http.ts:178:11)
at Sn.fetchPushControl (/webpack:/[name]/app/src/lib/api.ts:1322:7)
at or.refreshBranchProtectionState (/webpack:/[name]/app/src/lib/stores/app-store.ts:1100:39)
at f.performFailableOperation.retryAction (/webpack:/[name]/app/src/lib/stores/app-store.ts:4184:45)
at ys.performFailableOperation (/webpack:/[name]/app/src/lib/stores/git-store.ts:913:7)
at /webpack:/[name]/app/src/lib/stores/app-store.ts:4134:49
at or.withPushPullFetch (/webpack:/[name]/app/src/lib/stores/app-store.ts:4252:5) This means that GitHub Desktop treats the wiki like a GitHub repository. However, it does not provide the required API. So it is a normal Git repository. Note the first line in the log " Due to the use of 2FA, I'm setting a personal access token in my environment variable
|
Please fix this. Or, at the least, provide a way to backup the wiki from Github Desktop or the web interface. |
It would be nice to be able to use Github Desktop to work with a repo's wiki directly. I hope this is addressed at some point. |
GitHub Desktop version 3.2.9 (x64) , git version 2.41.0.windows.2 (64-bit), Windows 11 Home 22H2 OS build 22621.2283. Still reporting an error when attempting to clone a WIKI.
The Address being used in both was copied directly from the GitHub WIKI page using the button "Clone this wiki locally". |
Can anyone solve this? |
I come here to say that it's still broken |
(from xkcd 2881) |
+1 Please fix this. |
Back in the day when .wiki repositories were treated as "Other" i.e. not under GitHub.com or user/org headings in @desktop, everything seemed to work back then. Couldn't the repos for which GH API doesn't return the needed values be treated as classic git repos in the client? Or maybe shim it by checking the |
Pls cancel this not intersted
…On Tue, 19 Mar 2024, 3:12 am Jan Brasna, ***@***.***> wrote:
Back in the day when .wiki repositories were treated as "Other" i.e. not
under GitHub.com or user/org headings in @desktop
<https://github.com/desktop>, everything seemed to work back then.
Couldn't the repos for which GH API doesn't return the needed values be
treated as classic git repos in the client? Or maybe shim it by checking
the .wiki.git bit and make that fall back to "plain" git operations,
disabling all the PR/issue/meta features and just allow a vanilla git
access?
—
Reply to this email directly, view it on GitHub
<#3839 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BG7IKX4ERZ4VXNYR5XC23ZDYY44DNAVCNFSM4EMYPG3KU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBQGQ3TCNZYGI2Q>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
If you don't want to follow this thread, unfollow it. |
I found to be stable by treating the wiki repo as an external git service, such like gitlab/gitea/etc. Meaning. Taking the same way to fork the gitlab/gitea repos to GitHub. Let's pretend that I have a GitHub repo (KEINOS/wiki-test) which contains a wiki (KEINOS/wiki-test.wiki). Here are the steps I took:
As soon as the commit is merged, you'll see that the committed changes reflects both the working repo and the original wiki. Hope this helps for somebody. 🤞 My env and config info tesed$ date -R
Wed, 20 Mar 2024 12:17:50 +0900
$ # OS
$ sw_vers
ProductName: macOS
ProductVersion: 12.7.4
BuildVersion: 21H1123
$ # Git Version
$ git -v
git version 2.44.0
$ # GitHub Desktop
$ # Version 3.3.11 (x64)
$ # Git Configuration
$ git config --list --global
core.excludesfile=~/.gitignore_global
core.quotepath=false
core.ignorecase=false
filter.lfs.required=true
filter.lfs.clean=git-lfs clean -- %f
filter.lfs.smudge=git-lfs smudge -- %f
filter.lfs.process=git-lfs filter-process
user.name=KEINOS
user.email=github@keinos.com
user.signingkey=0E31BF0923FEC570
url.git@github.com:.pushinsteadof=https://github.com/
gpg.program=/usr/local/MacGPG2/bin/gpg
commit.gpgsign=true
credential.helper=osxkeychain
init.defaultbranch=main
$ git config --list
credential.helper=osxkeychain
filter.lfs.clean=git-lfs clean -- %f
filter.lfs.smudge=git-lfs smudge -- %f
filter.lfs.process=git-lfs filter-process
filter.lfs.required=true
core.excludesfile=~/.gitignore_global
core.quotepath=false
core.ignorecase=false
filter.lfs.required=true
filter.lfs.clean=git-lfs clean -- %f
filter.lfs.smudge=git-lfs smudge -- %f
filter.lfs.process=git-lfs filter-process
user.name=KEINOS
user.email=github@keinos.com
user.signingkey=0E31BF0923FEC570
url.git@github.com:.pushinsteadof=https://github.com/
gpg.program=/usr/local/MacGPG2/bin/gpg
commit.gpgsign=true
credential.helper=osxkeychain
init.defaultbranch=main
core.repositoryformatversion=0
core.filemode=true
core.bare=false
core.logallrefupdates=true
core.ignorecase=true
core.precomposeunicode=true
remote.origin.url=git@github.com:KEINOS/wiki-test-wiki.git
remote.origin.fetch=+refs/heads/*:refs/remotes/origin/*
branch.master.remote=origin
branch.master.merge=refs/heads/master
remote.upstream.url=git@github.com:KEINOS/wiki-test.wiki.git
remote.upstream.fetch=+refs/heads/*:refs/remotes/upstream/*
lfs.repositoryformatversion=0
$ # ENV Variables
$ env | grep GIT
GIT_CEILING_DIRECTORIES=/Users
GITHUB_ROOT=/Users/admin/GitHub
GITHUB_TOKEN=ghp_**snip** |
Description
After clone a wiki repository and close GithubDesktop can no longer identify the origin.
Version
GitHub Desktop version: 1.0.12 and 1.0.13
git rev-parse HEAD
: 372c2548553eac84ceef398fa0326c5815c919ccOS version: Microsoft Windows [version 6.3.9600]
Steps to Reproduce
Expected behavior: push to origin
Actual behavior: after close and reopen settings are losing, but after click in "push to origin" is failed and is showed this window:
Reproduces how often: Whenever the GithubDesktop is closed.
Logs
The text was updated successfully, but these errors were encountered: