Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error message does not go away #4242

Closed
iAmWillShepherd opened this issue Mar 14, 2018 · 2 comments
Closed

Error message does not go away #4242

iAmWillShepherd opened this issue Mar 14, 2018 · 2 comments
Labels
bug Confirmed bugs or reports that are very likely to be bugs help wanted Issues marked as ideal for external contributors priority-3 Bugs that affect small number of users and/or relatively cosmetic in nature

Comments

@iAmWillShepherd
Copy link
Contributor

iAmWillShepherd commented Mar 14, 2018 •
edited
Loading

Description

@nerdneha pointed this out in her comment over in #4216.

FYI, right now, if i put in a bunch of spaces into the input so that the input is all white space, the error message is The destination already exists which is weird to me. Removing the white spaces does not remove the error, the error persists until i type something that could theoretically exist

Version

  • GitHub Desktop: 1.1.0
  • Operating system: macOS and Windows

Steps to Reproduce

  1. Open the Clone Repository dialog
  2. Select the URL tab
  3. Press space
  4. Note the error message displayed
  5. Delete the blank space added
  6. Note the error message is still displayed

Expected Behavior

The error message to go away when the input is empty.

Actual Behavior

The error message is never cleared.

Additional Information

I addressed the issue not clearing issue in 94bb0d9.

clone-repo-whitespace

Logs
@iAmWillShepherd iAmWillShepherd added the bug Confirmed bugs or reports that are very likely to be bugs label Mar 14, 2018
@iAmWillShepherd iAmWillShepherd added this to the 1.1.x milestone Mar 14, 2018
@iAmWillShepherd iAmWillShepherd modified the milestones: 1.1.x, 1.2.x Apr 25, 2018
@tierninho tierninho added help wanted Issues marked as ideal for external contributors priority-3 Bugs that affect small number of users and/or relatively cosmetic in nature labels Oct 11, 2018
@Daniel-McCarthy
Copy link
Member

This issue appears to be resolved as of #6357.
I have tested it in the URL tab and I can no longer reproduce this.

@billygriffin
Copy link
Contributor

+1, thanks @Daniel-McCarthy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed bugs or reports that are very likely to be bugs help wanted Issues marked as ideal for external contributors priority-3 Bugs that affect small number of users and/or relatively cosmetic in nature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@iAmWillShepherd @Daniel-McCarthy @billygriffin @tierninho