Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wireup Syntax Highlighting for Crystal and Julia #6710

Closed
sweezyio opened this issue Jan 25, 2019 · 2 comments
Closed

Wireup Syntax Highlighting for Crystal and Julia #6710

sweezyio opened this issue Jan 25, 2019 · 2 comments
Labels
enhancement help wanted Issues marked as ideal for external contributors
Projects

Comments

@sweezyio
Copy link
Contributor

sweezyio commented Jan 25, 2019

Add support for syntax highlighting of Crystal Language and Julia Language

  1. Open a Crystal (.cr) or a Julia (.jl) file
  2. Observe that there is no syntax highlighting on the file.

Wireup CodeMirror to provide syntax highlighting
Add Julia and Crystal to the syntax highlighting docs.
Add configuration for Julia and Crystal to syntax highlighting file.

At the time of submitting this issue, I have created a pull request in desktop/highlighter-tests containing test files for Julia and Crystal.

(If this receives positive feedback I will move forward with the completion of the above objectives.

@shiftkey
Copy link
Member

@kennethsweezy sounds good to me

@shiftkey shiftkey added this to Available in Community via automation Jan 25, 2019
@sweezyio
Copy link
Contributor Author

sweezyio commented Jan 25, 2019 via email

@shiftkey shiftkey moved this from Available to In progress in Community Jan 25, 2019
Community automation moved this from In progress to Done Feb 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted Issues marked as ideal for external contributors
Projects
Development

No branches or pull requests

2 participants