credential-osxkeychain is not a git command

[cheshire137]

In 0.0.17, I added a newly initialized git repo to the app. I had previously pushed via the command line. The remote is using the https URL. When I made a commit via the app and hit the app's push button, I got this error in response:

[shiftkey]

@cheshire137 can you check under Preferences to see that you're signed into a GitHub account? I'm trying to reproduce this, and I think the fact I have git-credential-osxkeychain on my PATH might be an issue - is your setup similar?

$ which git-credential-osxkeychain
/usr/local/bin/git-credential-osxkeychain

[cheshire137]

I look signed in:

Ooh I get a different result for the command:

% which git-credential-osxkeychain
git-credential-osxkeychain not found

[joshaber]

It shouldn't care about osxkeychain unless authentication with the app's credentials fails.

You might try logging out and then back in again?

[shiftkey]

I could trigger this after logging in, and after relaunching the app. Seems to be not retrieving the user which then means envForAuthentication isn't setup correctly - which would explain why it's trying to use git-credential-osxkeychain

[shiftkey]

@cheshire137 can you tell me if this repository is listed under "GitHub" or "Other" when you look at it in the sidebar? For example, I was seeing this issue when I added the Desktop repository - and this was because it didn't consider it a GitHub repository until I'd signed in and had a refresh occur in the background:

I think we still need to setup GIT_ASKPASS to fail when not signed in, rather than have it fall through to whatever's been configured by Git.

[cheshire137]

Ooh, good intuition! It is indeed in my 'Other' section which is odd as the repo is definitely hosted on GitHub.

[shiftkey]

Interesting, so I can see the public repo but for some reason it's not being refreshed and populated with the GitHub API information.

One last thing to help reproduce it: could you list the remotes for the repository?

git remote -v

[cheshire137]

heroku	https://git.heroku.com/overwatch-counter-picker.git (fetch)
heroku	https://git.heroku.com/overwatch-counter-picker.git (push)
origin	https://github.com/cheshire137/overwatch-counter-picker.git (fetch)
origin	https://github.com/cheshire137/overwatch-counter-picker.git (push)

Think the heroku remote is interfering?

[shiftkey]

@cheshire137 yeah, I think that's related to the issue at hand. Thanks for all the info 💖

[shiftkey]

@cheshire137 actually one more question - is master setup to track heroku or origin?

git branch -vv

[cheshire137]

origin!

% git branch -vv
  database-stuff      a711082 [origin/database-stuff: gone] Add Heroku database steps to readme
  detect-cards-screen 911d49e [origin/detect-cards-screen: gone] Adjust template scale and Ana template
* master              b017f11 [origin/master] Use full scale sample-screenshot on index

[shiftkey]

@cheshire137 thanks! i've encountered an issue where I'm signed in but I don't have a token, which I think might be the root cause of this...

[cheshire137]

In my ~/.gitconfig, I do have this chunk:

[credential]
	helper = osxkeychain

[cheshire137]

I got a variation on this one, this time after hitting 'Push origin' and it spun for a bit without pushing my changes: