-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Desktop not compiling if directory path contains a space #9396
Comments
Thanks for the report! I've been able to reproduce the issue on my Window 10 VM |
How will this issue be fixed? |
@ruggi99 I'm doing some quick investigation since the error comes from |
@ruggi99 looks like this is a known problem with The issue got fixed a few days ago by electron/packager#1139, once a new version gets published with the fix we'll upgrade to it. |
@rafeca thank you for investigating this issue. |
@rafeca how about opening a PR to update only the cross-zip dependency and close this issue? I know it's not the best practice to edit manually the |
Sounds good to me as a temporary fix, so feel free to send the PR! Note that |
Describe the bug
If path of Desktop repo contains a space, then Desktop is not compiled, returning an error.
Version & OS
Github Desktop: development branch, OS: Windows 10
Steps to reproduce the behavior
yarn build:dev
Expected behavior
Compiling without error.
Actual behavior
Generates an error (image below) during compile.
Screenshots
Additional context
If path doesn't contain spaces (in my case) it compiles correctly.
If the error isn't repairable, I suggest to add a note in "docs/contributing/setup.md".
Or add the same note into troubleshooting section.
The text was updated successfully, but these errors were encountered: