Desktop not compiling if directory path contains a space

[ruggi99]

Describe the bug

If path of Desktop repo contains a space, then Desktop is not compiled, returning an error.

Version & OS

Github Desktop: development branch, OS: Windows 10

Steps to reproduce the behavior

1. Compile Desktop with yarn build:dev

Expected behavior

Compiling without error.

Actual behavior

Generates an error (image below) during compile.

Screenshots

Additional context

If path doesn't contain spaces (in my case) it compiles correctly.
If the error isn't repairable, I suggest to add a note in "docs/contributing/setup.md".
Or add the same note into troubleshooting section.

[rafeca]

Thanks for the report! I've been able to reproduce the issue on my Window 10 VM

[ruggi99]

How will this issue be fixed?

[rafeca]

@ruggi99 I'm doing some quick investigation since the error comes from electron-packager: I'm checking whether this is something that we can fix in Desktop or it's a bug on electron-packager. I'll give more details soon.

[rafeca]

@ruggi99 looks like this is a known problem with electron-packager (see electron/packager#1120).

The issue got fixed a few days ago by electron/packager#1139, once a new version gets published with the fix we'll upgrade to it.

[ruggi99]

@rafeca thank you for investigating this issue.

[ruggi99]

@rafeca how about opening a PR to update only the cross-zip dependency and close this issue? I know it's not the best practice to edit manually the yarn.lock file, but I think it won't break anything.

[rafeca]

Sounds good to me as a temporary fix, so feel free to send the PR!

Note that electron-packager is moving away from cross-zip to extract-zip (see electron/packager#1139), but either way upgrading cross-zip to v3.1.0 should be fine now.