Fix mentioning of users from a fork #10084
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pulling this out of my hack day work since it can stand on its own.
If you clone a fork today and try to autocomplete users or issues those issues and mentionable users will always be derived from the fork which for the majority case means that users will not be able to autocomplete (forks are overwhelmingly used only to contribute to the upstream).
Since we introduced the workflow preferences in #9842 we've let users tell us how they want to work with their fork.
This PR takes that preference into account so that if say @billygriffin attempts to autocomplete issues or users in https://github.com/billygriffin/desktop with the "To contribute to the parent repository" setting selected he'll now see the issues and mentionable users from https://github.com/desktop/desktop instead.
Screenshots
Release notes
Notes: [Improved] Autocompleting issues or users in forks now respect configured fork behavior