Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mentioning of users from a fork #10084

Merged
merged 4 commits into from
Jun 29, 2020

Conversation

niik
Copy link
Member

@niik niik commented Jun 25, 2020

Description

Pulling this out of my hack day work since it can stand on its own.

If you clone a fork today and try to autocomplete users or issues those issues and mentionable users will always be derived from the fork which for the majority case means that users will not be able to autocomplete (forks are overwhelmingly used only to contribute to the upstream).

Since we introduced the workflow preferences in #9842 we've let users tell us how they want to work with their fork.

This PR takes that preference into account so that if say @billygriffin attempts to autocomplete issues or users in https://github.com/billygriffin/desktop with the "To contribute to the parent repository" setting selected he'll now see the issues and mentionable users from https://github.com/desktop/desktop instead.

Screenshots

image

Release notes

Notes: [Improved] Autocompleting issues or users in forks now respect configured fork behavior

@tierninho tierninho self-requested a review June 25, 2020 20:59
tierninho
tierninho previously approved these changes Jun 25, 2020
Copy link
Contributor

@tierninho tierninho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out in OSX/WIN and works well and super snappy.

Should we include a line item for this here or too minor of a change? https://github.com/desktop/desktop/blob/forks-doesnt-need-to-be-this-lonely/app/src/ui/repository-settings/fork-contribution-target-description.tsx#L19

rafeca
rafeca previously approved these changes Jun 26, 2020
Copy link
Contributor

@rafeca rafeca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niik
Copy link
Member Author

niik commented Jun 26, 2020

Should we include a line item for this here or too minor of a change? https://github.com/desktop/desktop/blob/forks-doesnt-need-to-be-this-lonely/app/src/ui/repository-settings/fork-contribution-target-description.tsx#L19

That's a great question, I don't feel super strongly about it but maybe it should. I wasn't part of the design discussions around that view but it seems like it's pretty exhaustive right now so I've added this there as well.

image

@niik niik dismissed stale reviews from rafeca and tierninho via e472e1e June 26, 2020 13:21
@niik niik requested review from rafeca and tierninho June 26, 2020 13:21
@niik niik merged commit 5ed11ba into development Jun 29, 2020
@niik niik deleted the forks-doesnt-need-to-be-this-lonely branch June 29, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants