Repositories #101
Repositories #101
Conversation
|
👀 🙏 |
|
This diff is more reasonable now 🎉 |
|
| return new Repository() | ||
| const gitHubRepository = json.gitHubRepository | ||
| if (gitHubRepository) { | ||
| return new Repository(json.path, GitHubRepository.fromJSON(json.gitHubRepository)) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
This all seems rather nice. Anything in particular you'd like me to focus on when reviewing/testing? |
The things that come to mind are: (1) repositories persist across relaunches, (2) repositories show up in the list when dragged in. |
| @@ -27,7 +27,6 @@ export default class SharedProcess { | |||
| this.window.loadURL(`file://${__dirname}/shared.html`) | |||
|
|
|||
| if (process.env.NODE_ENV === 'development') { | |||
| this.window.show() | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Changes look good, tested drag-and-drop and persistence. Just that note about the dev tools experience and this is good to 🚢 |
|
🌁 |
|
🎱 |
| private dispatch<T>(action: Action): Promise<T> { | ||
| const copiedAction = Object.assign({}, action) | ||
| delete copiedAction.name | ||
| return this.send(action.name, action) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Dependent on #97
Add repositories to the app via dragon drop and store them in IndexedDB.