Autocompletion tweaks, consistency between providers #10168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And it happens to match what we do on GitHub.com
rafeca
approved these changes
Jul 10, 2020
| @@ -185,6 +182,7 @@ export class GitHubUserStore extends BaseStore { | |||
| .sort( | |||
| (x, y) => compare(x.ix, y.ix) || compare(x.user.login, y.user.login) | |||
| ) | |||
| .slice(0, maxHits) | |||
There was a problem hiding this comment.
yay! I think this is way better than the previous logic, which could discard items that would have appeared at the top of the list 😀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌵 Depends upon #10121, please review that first 🌵
Description
Continuation of #10121. Attempts to provide a consistent logic between issues, user, and emoji autocompletion providers. Introduces an exact replica of the cache implemented for the user autocompletion in #10121.