Support deploying arm64 builds #11683
Conversation
README.md
Outdated
| @@ -27,6 +28,7 @@ Want to test out new features and get fixes before everyone else? Install the | |||
| beta channel to get access to early builds of Desktop: | |||
|
|
|||
| - [macOS](https://central.github.com/deployments/desktop/desktop/latest/darwin?env=beta) | |||
| - [macOS (M1 Chip)](https://central.github.com/deployments/desktop/desktop/latest/darwin-arm64?env=beta) | |||
There was a problem hiding this comment.
| - [macOS (M1 Chip)](https://central.github.com/deployments/desktop/desktop/latest/darwin-arm64?env=beta) | |
| - [macOS (Apple Silicon)](https://central.github.com/deployments/desktop/desktop/latest/darwin-arm64?env=beta) |
I tend to think this is the "best way" to highlight these things, I think a future Mac could very well be shipping with an M2 or M1X (or so my sources say)
There was a problem hiding this comment.
Good point! I chose M1 because that's how Apple showcases it and I don't see any references to Apple Silicon, but I agree it's probably more accurate and future-proof 😄 Thanks!!
|
Question, if m1 user already has PS (intel) installed trough brew, will this (PS m1 support) uninstall and install m1 version when they update? If not, then I think that's a good ide to have. |
| @@ -93,6 +93,7 @@ jobs: | |||
| - name: Publish production app | |||
| run: yarn run publish | |||
| env: | |||
| npm_config_arch: ${{ matrix.arch }} | |||
There was a problem hiding this comment.
This is what's used to tell our scripts about the target architecture.
| if ( | ||
| enableUpdateFromRosettaToARM64() && | ||
| remote.app.runningUnderRosettaTranslation === true | ||
| ) { | ||
| const url = new URL(updatesURL) | ||
| url.searchParams.set('architecture', 'arm64') | ||
| updatesURL = url.toString() | ||
| } |
There was a problem hiding this comment.
This is needed because __UPDATES_URL__ is set at compile time, so we can't set it to look for arm64 for users who downloaded the x64 build to then run it on an Apple Silicon machine.
Description
This PR prepares our build scripts to deploy arm64 binaries to Central. Depends on github/central#500
Changes:
darwin-arm64andwin32-arm64).Release notes
Notes: no-notes