Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump more dependencies for macOS arm64 #12091

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Conversation

sergiou87
Copy link
Member

Description

This PR bumps 3 dependencies:

Release notes

Notes: no-notes

Bump desktop-trampoline to a version with good prebuilt binaries for arm64
Copy link
Contributor

@tidy-dev tidy-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergiou87 sergiou87 merged commit 5c18fb9 into development Apr 29, 2021
@sergiou87 sergiou87 deleted the more-arm64-binaries branch April 29, 2021 13:58
@jensenharris
Copy link

jensenharris commented Apr 29, 2021

When I install 2.8.1-beta2 on my Apple Silicon Mac without Rosetta installed, it immediately prompts me:

Rosetta Required

Looks like still something to sort out here? I see the app type as Intel.

I installed through the Beta link in readme.md: https://central.github.com/deployments/desktop/desktop/latest/darwin?env=beta

@sergiou87
Copy link
Member Author

@jensenharris yes, that link downloads the x64 beta. I added a new link to the README.md in https://github.com/desktop/desktop/pull/12098/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R30 but that branch hasn't been merged yet.

The link for arm64 betas for macOS is https://central.github.com/deployments/desktop/desktop/latest/darwin-arm64?env=beta (notice the -arm64 suffix)

@jensenharris
Copy link

You are a hero @sergiou87. Thanks for your work bringing this across the last mile! The build at the new link now works fine on my Rosetta-less M1. I really appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants