Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable partial change selection in split view #12129

Merged
merged 2 commits into from
May 4, 2021

Conversation

sergiou87
Copy link
Member

@sergiou87 sergiou87 commented May 4, 2021

Description

This PR addresses two issues:

Fixes #12109

Screenshots

Screen.Recording.2021-05-04.at.19.01.16.mov

Release notes

Notes: [Fixed] Disable partial change selection in split view while whitespace changes are hidden.

@sergiou87 sergiou87 requested a review from tidy-dev May 4, 2021 17:06
@sergiou87 sergiou87 changed the title Warn users about diff being read-only when hiding whitespace changes Disable partial change selection in split view May 4, 2021
Copy link
Contributor

@billygriffin billygriffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergiou87 How would you feel about adding Fixes #12109 to this PR as well?

Copy link
Contributor

@tidy-dev tidy-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ Tested it out (on macOs) and works great!

@sergiou87
Copy link
Member Author

Thanks @billygriffin that's the one I wanted to reference 🤦‍♂️

@sergiou87 sergiou87 enabled auto-merge May 4, 2021 17:20
This was referenced May 4, 2021
@sergiou87 sergiou87 merged commit 924508b into development May 4, 2021
@sergiou87 sergiou87 deleted the hide-whitespace-fixes branch May 4, 2021 17:29
Copy link

@Body87 Body87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tameryldz

This comment was marked as off-topic.

@tameryldz

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot stage per line in unified diffs when hiding whitespace
5 participants