Allow creating branches from a specific commit #12160
Conversation
There was a problem hiding this comment.
✨ Code looks great! Tested it out and works like a charm. I am excited to use this feature!
A suggestion: (and if you think it is worth it - could be a separate PR)
We have easy access to the commit summary at this point. It may be more user friendly to show the summary and the sha?
We do this on the progress dialogs for rebase/cherry-picking so I also think it would be more consistent. (Below is just a quick mock up, there may be a better way to put it to be friendly to long summaries and maybe styling should use a bold/emphasized instead of in quotes)
Side note: "from your repository" may be redundant?
| @@ -199,6 +200,17 @@ export class CommitListItem extends React.PureComponent< | |||
| }, | |||
| ] | |||
|
|
|||
| items.push({ | |||
| label: __DARWIN__ | |||
| ? 'Create Branch From This Commit' | |||
There was a problem hiding this comment.
| ? 'Create Branch From This Commit' | |
| ? 'Create Branch from This Commit' |
Where mac uses title case and from is a preposition, it should be lowercase.
There was a problem hiding this comment.
After testing it out,
I noticed the revert and cherry-pick menu item does not have the word 'This' in it. Just a suggestion, but for consistency we could leave This out.
Co-Authored-By: tidy-dev <75402236+tidy-dev@users.noreply.github.com>
|
I implemented both of your suggestions, I think they make a lot of sense, so thank you!! ❤️
|
Description
Fixes #3474
This PR just adds a new action to the commit context menu to allow creating branches from a specific commit.
Screenshots
Screen.Recording.2021-05-06.at.16.30.31.mov
Release notes
Notes: [Added] Create branches from any commit in your repository