Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same width for hunk expansion handles as we do for line numbers #12887

Merged
merged 1 commit into from Sep 1, 2021

Conversation

niik
Copy link
Member

@niik niik commented Sep 1, 2021

Description

Noticed that the diff expansion handle gutters didn't use the same size as line numbers in the unified diff view

Screenshots

Before

image

After

image

Release notes

Notes: no-notes

Copy link
Member

@sergiou87 sergiou87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I just noticed that in split mode we show the line numbers at the left (of each half) for commits, but in the center for the Changes tab 🤯

What's the reasoning behind that?

Anyway, this can be merged :shipit: Thanks for taking care of it ❤️

@sergiou87 sergiou87 merged commit 1fbf179 into development Sep 1, 2021
@sergiou87 sergiou87 deleted the contain-yourself branch September 1, 2021 15:25
@niik
Copy link
Member Author

niik commented Sep 3, 2021

What's the reasoning behind that?

It's so that you can drag to select multiple lines in both columns in the changes view which isn't needed in the history view. It's a UX problem that dotcom hasn't needed to solve 😄

@desktop desktop deleted a comment from Djamma1986 Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants