Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error messages #12902

Merged
merged 2 commits into from Sep 7, 2021
Merged

Update error messages #12902

merged 2 commits into from Sep 7, 2021

Conversation

ghost
Copy link

@ghost ghost commented Sep 3, 2021

Description

This updates two error messages defined in app-store.ts.

Message 1 (line 5273)

  • Fail goes with to and the infinitive rather than with the gerund. Here’s an example from the Cambridge Dictionary: “John failed to turn up for football practice yesterday” (emphasis added).
  • Repository directory needs an article.
  • The construction “a common reason . . . is if” is unsuitable here. The conjuction if attaches to is, the sentence suggesting that an undescribed reason occurs under a certain condition. “A common reason . . . is that” will fulfill the function needed.
  • I believe the second sentence should be referring to the repository directory or a part of it, not any file or directory at all.

Message 2 (lines 5758–5760)

See the third point above. I’ve also replaced cause with reason for consistency.

Release notes

Notes: no-notes

@tidy-dev tidy-dev self-requested a review September 7, 2021 17:26
Copy link
Contributor

@tidy-dev tidy-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ Thank you for the much better verbiage!

@tidy-dev tidy-dev merged commit 2abcab5 into desktop:development Sep 7, 2021
@ghost
Copy link
Author

ghost commented Sep 8, 2021

Happy to help!

@desktop desktop deleted a comment from Hakim77pixel Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant