Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format absolute dates using Intl.DateTimeFormat #14123

Merged
merged 7 commits into from
Mar 9, 2022
Merged

Conversation

niik
Copy link
Member

@niik niik commented Mar 8, 2022

Description

Based on #14119 this PR switches us to using Intl.DateTimeFormat when converting dates to strings for human consumption.

Format Output
formatDate: full/short Tuesday, March 8, 2022 at 6:23 PM
moment: LLLL Tuesday, March 8, 2022 6:23 PM
formatDate: medium/short Mar 8, 2022, 6:23 PM
moment: lll Mar 8, 2022 6:23 PM
formatDate: medium Mar 8, 2022
moment: ll Mar 8, 2022

Release notes

Notes: no-notes

Copy link
Member

@sergiou87 sergiou87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I love where this is going… 🔥 moment🔥

@sergiou87 sergiou87 self-assigned this Mar 9, 2022
Base automatically changed from no-one-ever-talks-about-centiseconds-any-more to development March 9, 2022 12:00
Copy link
Contributor

@tidy-dev tidy-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants