PR View: Popover Dropdown component #15339
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #15326
Description
This PR separates out the popover dropdown logic of the branch select component into a new component that I can reuse for the commit list popover.
I also updated the styles to match the figma better.. however, based on our accessibility meeting recently, I figured the link look would be recommended to be underlined to get the required contrast to be accessible, so I added that. But, now that I see it, I think that the design of this component should be revisited. Maybe since this is a button, it should look like a button. It looks like a button on dotcom (when editable) and we do have a dropdown button to context menu elsewhere in our app (repository add button). But, that I will leave to another PR, this PR is to add the dropdown to popover functionality so I can add the commit selection dropdown.
cc: @gavinmn
Screenshots
Screen.Recording.2022-09-22.at.11.49.55.AM.mov
Release notes
Notes: no-notes