Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tab size preference settings #15841

Closed
wants to merge 4 commits into from
Closed

Add tab size preference settings #15841

wants to merge 4 commits into from

Conversation

novialriptide
Copy link
Contributor

Closes #15561

Description

Screenshots

image
image

Release notes

Notes: Added tab size preferences

Additional Information

I actually need help finalizing this... once the user has chosen a tab size, they need to manually reload the page in order to see the new changes and I spent around 30 minutes trying to find how to refresh the content but failed to do so. I was wondering if any of the experienced developers could help assist me?

@novialriptide novialriptide changed the title Tab size changer Add tab size preference settings Dec 29, 2022
@angusdev
Copy link
Contributor

Need to consider tab stop instead of just replace with spaces. See below screen (first is production version, second is the PR version). Although the current behaviour also has bug, it should skip the (+) sign when calculating tab stop.

Screenshot 2023-01-10 at 11 17 54 PM

@novialriptide
Copy link
Contributor Author

novialriptide commented Jan 12, 2023

@angusdev

Thanks for noticing, the school semester is about to start soon 🥲, but I'll work on it in a bit.

@sergiou87
Copy link
Member

Hey @novialriptide !! Thank you for your contribution 🙇‍♂️

We (the Desktop team) chatted about this today and think it'd be a nice addition, but just as github.com does, it shouldn't be in the diff viewer. Instead, it should be in some appearance / diff settings in the app settings dialog. Where exactly is hard to tell, since we have many settings already, but something we'd rather discuss (and agree) in the linked issue #15561 before any attempt of implementation is made.

Just to be clear, the reason we want to move the conversation to #15561 until all the details are agreed, is to avoid having too much noise in the PR list: we have too many PRs open and it's hard to keep up, especially if they require some discussion that could take days or weeks (we're a pretty small team 😳 ). So we're gonna close this PR and it can be reopened once we all agree on what will be done.

Sorry for any inconvenience and thank you again for your work! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tab size setting for diffs
3 participants