Remove unnecessary delay in announcing committing status #16371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #16340
Description
Got some feedback from the accessibility team, the delay introduced in the last pr not necessary because the "Committing to branch name" would be announced if there is a significant wait on committing. Thus, I removed that. However, there was a lot of precedence on the commit completion being announced. I found with just having the "Committed just now" that it would not reliably announced after the first commit of opening Desktop. Thus, I have changed to announce "Committed just now - Summary - sha (short sha)" The short sha is required to always provide a distinct message.
Screenshots
CleanShot.2023-03-24.at.10.59.01.mp4
Release notes
Notes: [Improved] Commit completion status is announced by screen readers.