Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace undo link with button #17373

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Replace undo link with button #17373

merged 2 commits into from
Sep 19, 2023

Conversation

sergiou87
Copy link
Member

xref. https://github.com/github/accessibility-audits/issues/5626

Description

The undo link we used to display after resolving conflicts with one of our predefined actions should be a button to meet the accessibility standards. This PR makes that change.

Screenshots

Screen.Recording.2023-09-11.at.13.40.05.mov

Release notes

Notes: [Improved] Undo link when resolving conflicts is now a button

@sergiou87
Copy link
Member Author

I looked for regressions (given I changed the style of column-left) but couldn't find any. This should be ready to go!

@sergiou87 sergiou87 marked this pull request as ready for review September 11, 2023 14:22
Copy link
Member

@niik niik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergiou87 sergiou87 merged commit 5a14215 into development Sep 19, 2023
8 checks passed
@sergiou87 sergiou87 deleted the undo-link-to-button branch September 19, 2023 07:01
This was referenced Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants