Reword repository indicator fetch setting #17389
Conversation
There was a problem hiding this comment.
This is already loads better than what we've got and I'd be happy to take this improvement. I though about trying an angle where we title the setting after what it enables and not what it does but I couldn't get it to not be too wordy
[ ] Show which repositories have local or remote changes in the repository list
|
- Allows the display of up-to-date status indicators in the repository - list. Disabling this may improve performance with many repositories. + + This requires the periodic fetching of repositories that are not + currently open. Turning this off will not stop the periodic fetching + of your open repository. |
app/src/ui/preferences/advanced.tsx
Outdated
| > | ||
| This requires the periodic fetching of repositories that are not | ||
| currently open. Turning this off will not stop the periodic fetching | ||
| of your open repository. |
There was a problem hiding this comment.
I like @oscarllann angle on performance. Maybe it gets excessively wordy but adding something like... "but will improve overall performance of the app for users with many repositories" could be useful to our users.
I do prefer this approach as it is more direct. I had something long on one iterations but was still using "status indicators", I like the explanation of the behavior better. Probably the only thing I prefer about "status indicators" is that it tells me that is likely referring to the "icon" stuff in the repository list. I think that this is going to be a verbose setting no matter what because it is hard to concisely communicate. I am going to mull on this a bit see if I can think of anything different.
Good call out -> having the reason for the setting makes sense.
I was leery of the "up-to-date" verbiage since it is a periodic fetch so it is not always up-to-date :D |
Co-Authored-By: Markus Olsson <634063+niik@users.noreply.github.com>
|
Latest thoughts.. but the verboseness isn't pretty with the checkbox centering.. But could fix if we decide we like some wording that is two lines.
|
|
Yeah that doesn't look good 😭 What do you think about moving some of that info to the description text? |
|
Yeah. I definitely like a one line setting better. But, man, that wall of text. :P I split it into two paragraphs in hopes of making it scannable.
|
|
Alternative to wall of text above .. more scannable wall of text?
|
|
I prefer the two paragraphs better! |
tidy-dev
force-pushed
the
background-fetch-setting-wording
branch
from
3b48e74
to
2d493e7
Compare
|
PR currently 
|
Related Issues:
#10687
GitHub Desktop fetching even with auto fetch disabled
Description
The "Periodically fetch and refresh status of all repositories" is to toggle the background fetching of repositories in order to display the status indicators in the repository list. Unfortunately, we have had users interpret the setting to mean it should stop all the periodic fetching including their currently open one. However, this is not true, GitHub Desktop will still periodically fetch the open repository in order to keep it in sync with it's remote.
Further explanation of why this doesn't turn off fetching in the currently open repository:
Therefore, having a setting to turn all periodic fetching off would require a bit of research to determine all the consequences and handle all the use cases of the open repository.
Screenshots
Release notes
Notes: [Improved] Clarified the outcome of toggling the setting under "Background Updates" in the "Advanced" settings.