Add aria-describedby to merge/rebase/squash button #17448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, the tooltip would override (setting or removing) whatever the target element had set as `aria-describedby`. This was evident when trying to set a custom `aria-describedby` to an element with a tooltip: the `aria-describedby` attribute wouldn't make it to the DOM 😑 With this change, the tooltip will add or remove itself, respecting whatever was in there before.
tidy-dev
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref. https://github.com/github/accessibility-audits/issues/5576
Description
This PR adds an
aria-describedbyattribute to the rebase/merge/squash button, referencing the element describing the outcome of the operation that we render right above the button itself. After some testing, I noticed VoiceOver would only read this when using Electron 26 but not with Electron 24 🤯It also fixes a bug in the tooltips that weren't respecting existing
aria-describedbyattributes in the target element. Kudos to @tidy-dev for finding out this bug!! 🙇♂️Screenshots
CleanShot.2023-09-27.at.08.57.56.mp4
Release notes
Notes: [Improved] When focusing the rebase/merge/squash button, screen readers announce the outcome of the operation