Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show toggle co-authors button text when it's focused via keyboard navigation #17464

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

sergiou87
Copy link
Member

xref. https://github.com/github/accessibility-audits/issues/4941

Description

With the changes in this PR, the Add Co-Authors / Remove Co-Authors text displayed right next to the co-authors button when it's hovered will be displayed also when that button is focused via keyboard navigation (i.e. when it has :focus-visible)

Screenshots

Screen.Recording.2023-09-29.at.17.47.05.mov

Release notes

Notes: [Improved] Display co-authors button additional information when it's focused via keyboard navigation

Copy link
Contributor

@tidy-dev tidy-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ Works great!

@sergiou87 sergiou87 merged commit 036aa67 into development Oct 3, 2023
8 checks passed
@sergiou87 sergiou87 deleted the show-toggle-coauthors-msg-on-focus branch October 3, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants