Fix left panel scrollbar when pasting long text in commit summary #17472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tidy-dev
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
✨ Works great! I love that it is a more targeted solution than what I suggested in the other PR.
One thing I was thinking tho is that, this PR targets the root cause, my suggestion targets the side panel behaving as expected regardless of the behavior of it's children. Do you think it would still make sense to add the overflow-x:hidden to the side panel just in case some other child component eventually misbehaves?
Approving this any which way as I think it is a plenty proper solution. :)
|
I think that could hide other potential issues in specific components, so at least right now I'd rather keep the side panel unchanged 🤔 |
Plentywolf
reviewed
Nov 2, 2023
| @@ -4,6 +4,11 @@ | |||
| position: relative; | |||
| display: flex; | |||
| flex-direction: column; | |||
|
|
|||
| // Overflow must be hidden to prevent the "invisible caret" to generate an | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17320
Supersedes #17466
Description
While testing #17466 I noticed that didn't fix the issue for me, but the problem was clearly related to pasting long strings into the commit summary textbox. And then it was easily solved when a single character was entered or removed.
The problem seemed to be that the caret coordinates were updated immediately, but not the textbox inner scroll, so the textbox scroll X position remained at 0, but the caret, after pasting the long text, was far in the X axis, out of the boundaries of the textbox.
This PR includes two changes to address this issue:
overflow: hiddento the textbox so even when the invisible caret is rightfully out of the boundaries of the textbox, Desktop doesn't show scrollbars.Screenshots
Screen.Recording.2023-10-02.at.08.43.10.mov
Release notes
Notes: [Fixed] Pasting long texts in the commit summary textbox does not show a scrollbar in the left pane