Add aria-label
to "compare" filter textbox
#17488
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref. https://github.com/github/accessibility-audits/issues/4884
Description
This PR adds an
aria-label
to the filter textbox of the Compare feature in the History tab.To be honest, I'm not entirely sure if this adds any value: screen readers already announced the placeholder text (and still do), so 馃し
I'm also open to suggestions of the label to use 馃槀
Screenshots
CleanShot.2023-10-04.at.18.35.51.mp4
Release notes
Notes: [Improved] Added accessibility label to filter textbox in the History tab