Use role=alertdialog for errors when trying to do operations with local changes
#17519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tidy-dev
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
✨ Works great!
This is getting a jump on the error dialog audit! :) Mind merging this fix into #17459 and doing a new test release for the audit and just post a comment on the PR stating which release version is the latest. :)
|
Ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found in https://github.com/github/accessibility-audits/issues/5649#issuecomment-1751481852
Description
This PR just adds the
role="alertdialog"attribute to the error Desktop displays when attempting certain operations (like reordering a commit) when there are local changes present.Screenshots
CleanShot.2023-10-09.at.10.14.56.mp4
Release notes
Notes: [Fixed] Screen readers announce contents of error dialog when attempting to perform certain operations while local changes are present