Onboarding improvements: No local changes blank slate #6445
Conversation
niik
added
the
ready-for-review
A temporary artefact pending support to disable the action buttons when actions weren't available. This has been addressed. |
|
All tests passing as of 760187f. 🏁 Should there be a scroll bar when zoomed in? I am not allowed to scroll at all. |
| <h1>No local changes</h1> | ||
| <p> | ||
| You have no uncommitted changes in your repository! Here are | ||
| some friendly suggestions for what to do next. |
There was a problem hiding this comment.
| some friendly suggestions for what to do next. | |
| some suggestions for you: |
There was a problem hiding this comment.
Could you provide some context as to why you want to make this change? Suggested changes are lovely for typos or easy to spot mistakes but don't convey enough context on their own.
There was a problem hiding this comment.
I suggested these changes because I thought my changed version read better, but I don’t feel strongly either way.
@tierninho Good shout. I forgot about zooming. I took a stab at addressing this and added some responsive styling at high zoom levels to make it at least somewhat usable at the min window size. |
There was a problem hiding this comment.
This all looks fine to me! I chatted with @niik about some future refactoring we could do to remove the dependency on Menu for these actions but that is a larger project we can address in the future.
|
Noticed that clicking from outside of the Desktop app into one of the new onboarding buttons is not functional. Not sure if we have rules around this, but wanted to point it out. |
|
@tierninho which OS? |
|
Mac 10.14, v1.6.0-beta2 |
|
@tierninho the reason why I ask is that ages ago we added #3843 which was a specific Electron flag around focus and handling that first click, and I'd like to figure out why that doesn't seem to work with this change. I did a quick test of |
|
@shiftkey seeing it work now too. Must have been a one-off fluke with my setup. Sorry for the false alarm. |
|
Is it possible to not have this constantly popping up when there are changes? Every time I click a file in the "Changes" tab this screen flashes up for half a second before showing the expected diff. It wasn't so bad before when it was a light grey screen with small text, but now it's super jarring. |
Overview
This is part of the onboarding improvements (see #6365 and #5686)
Description
The mockups
Possible other actions
Current state
Release notes
Provides more obvious paths for what users are able to do when there are no uncommitted changes
TODO
Animations when actions appear/disappear?Punt in this PR, implemented separately.cc @billygriffin