extract and isolate error handling from GitStore internals #6613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiftkey
added
the
tech-debt
shiftkey
force-pushed
the
experiment-isolate-error-handling
branch
5 times, most recently
from
df2ed68
to
096d22e
Compare
shiftkey
force-pushed
the
experiment-isolate-error-handling
branch
20 times, most recently
from
097f03a
to
f9764e7
Compare
shiftkey
force-pushed
the
experiment-isolate-error-handling
branch
4 times, most recently
from
097f03a
to
f9764e7
Compare
shiftkey
force-pushed
the
experiment-isolate-error-handling
branch
10 times, most recently
from
ad98fb6
to
16f8188
Compare
shiftkey
force-pushed
the
experiment-isolate-error-handling
branch
6 times, most recently
from
a18cd6c
to
5bf0c0e
Compare
nerdneha
moved this from PR Draft or Needs to be Prioritized
to PR Priority
in PR Priority
shiftkey
force-pushed
the
experiment-isolate-error-handling
branch
2 times, most recently
from
b8432e1
to
e098ac5
Compare
nerdneha
moved this from PR Priority
to PR Draft or Needs to be Prioritized
in PR Priority
shiftkey
force-pushed
the
experiment-isolate-error-handling
branch
from
e098ac5
to
45531c5
Compare
|
Closing this out for now to ponder on alternative ways to present this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
First part of #6595
Currently the default error handling has been owned by
GitStore, but as we've moved towards running Git operations outside of aGitStore(because we don't need to cache the result), there has been some confusion about the right way to leverage the inbuilt error handling so that unhandled errors do not bring down the app.Description
This PR extracts the logic for
GitStore.createFailableOperationHandlerinto it's own module, and provides a more familiarwithErrorHandlingfunction in the places where this is currently used.Release notes
Notes: no-notes