Only render NoChanges when there are.. no changes #6660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niik
added
the
ready-for-review
outofambit
approved these changes
Jan 18, 2019
|
tried out locally and verified it fixes the issue ✅ |
|
Tested and LGTM. I did spot a similar "No File Selected" placeholder when scrolling History commits (both as a whole and individual files). Not as much as an eyesore, but still somewhat distracting. Shall I open a new issue?
|
This was referenced Jan 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Apparently we've been using the
NoChangescomponent as a fallback component while we're waiting for the Diff to load. It's been this way since forever but the last release with the redesigned no changes blank slate made it more noticeable, especially on slower environments.This PR ensures that we're only rendering the
NoChangescomponent when there are, in fact, no changes.Closes #6658
Release notes
Notes:
[Fix] Don't show the no local changes view when switching between changed files