Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only render pr bubble if there are PRs #7258

Merged
merged 2 commits into from Apr 11, 2019
Merged

Only render pr bubble if there are PRs #7258

merged 2 commits into from Apr 11, 2019

Conversation

niik
Copy link
Member

@niik niik commented Apr 11, 2019

Overview

This is part of the larger PR work that I'm doing and is extracted here in an attempt to reduce the size of what's going to be a fairly large PR for the bigger story.

Description

This removes the count bubble in the PR tab inside of the branches foldout when there are no PRs

image

This is now consistent with the behavior of the count bubble in the changes tab which only shows when there are changes.

image

image

Release notes

Notes: no-notes

@niik niik added the ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Apr 11, 2019
@shiftkey shiftkey self-assigned this Apr 11, 2019
Copy link
Member

@shiftkey shiftkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM! 🎉

@shiftkey shiftkey merged commit 848eccf into development Apr 11, 2019
@shiftkey shiftkey deleted the drop-pr-bubble branch April 11, 2019 13:36
@konifar

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants