New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle warnings if stash creation encounters permission issue #7351
Conversation
@shiftkey Build and tested 5a34e36 locally. I can confirm unblocked the expected workflow. What happens is:
Log:I had to redact some of the file names but for the most part you can see what is happening |
Moving this to
|
@iAmWillShepherd I re-requested a review from you to confirm whether you'd like to see this merged for the beta, or whether you want to investigate alternatives... |
47dd7c1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
Overview
Related to #7344
Description
I'm not a huge fan of this current patch, but it's targeted to this specific scenario:
git stash push
runs and creates the stash (including untracked files)stderr
about the problem pathThis patch is supposed to:
1
exit codestderr
to ensure noerror:
messages existstderr
and continue@say25 as you had a concrete reproduction of the permissions denied error, are you able to verify this fix at some stage by building this PR branch locally and trying it with that problem repository?
Release notes
Notes:
[Fixed] stashing when untracked path is not accessible will not block checkout