Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrapping up docs about rebase flow #7401

Merged
merged 10 commits into from May 2, 2019
Merged

wrapping up docs about rebase flow #7401

merged 10 commits into from May 2, 2019

Conversation

shiftkey
Copy link
Member

@shiftkey shiftkey commented Apr 25, 2019 •
edited

Overview

I made a start on this a while ago and it'd be nice to wrap this up before 1.7 goes out.

Rendered Markdown

Description

Release notes

Notes: no-notes

@shiftkey shiftkey added the docs Issues and pull requests related to documentation work on the project label Apr 25, 2019
@shiftkey shiftkey added this to Needs Triage in Rebase Epic via automation Apr 25, 2019
@shiftkey shiftkey moved this from Needs Triage to 1.7.0 release in Rebase Epic Apr 25, 2019
@nerdneha nerdneha added this to PR Needs Triage in PR Priority Apr 26, 2019
@nerdneha nerdneha removed this from PR Needs Triage in PR Priority Apr 26, 2019
@nerdneha nerdneha added this to PR Needs Triage in PR Priority Apr 26, 2019
@nerdneha nerdneha moved this from Needs to be Prioritized to PR Draft in PR Priority Apr 26, 2019
@shiftkey shiftkey marked this pull request as ready for review April 29, 2019 20:21
@shiftkey shiftkey added the ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Apr 29, 2019
@shiftkey shiftkey moved this from 1.7.0 release to Beta - 2nd May in Rebase Epic Apr 29, 2019
@shiftkey shiftkey moved this from PR Draft to PR Reviewable Priority in PR Priority Apr 30, 2019
@iAmWillShepherd iAmWillShepherd self-assigned this May 1, 2019
iAmWillShepherd
iAmWillShepherd suggested changes May 1, 2019
View reviewed changes
docs/technical/rebase-flow.md Outdated Show resolved Hide resolved
docs/technical/rebase-flow.md Outdated Show resolved Hide resolved
docs/technical/rebase-flow.md Outdated Show resolved Hide resolved
docs/technical/rebase-flow.md Outdated Show resolved Hide resolved
docs/technical/rebase-flow.md Outdated Show resolved Hide resolved
PR Priority automation moved this from ⭐️ PR Reviewable Priority ⭐️ to Review in progress May 1, 2019
iAmWillShepherd and others added 3 commits May 1, 2019 11:59
@iAmWillShepherd @billygriffin
Update docs/technical/rebase-flow.md
ff09069 
Co-Authored-By: billygriffin <5091167+billygriffin@users.noreply.github.com>
@iAmWillShepherd @billygriffin
Update docs/technical/rebase-flow.md
450ba6f 
Co-Authored-By: billygriffin <5091167+billygriffin@users.noreply.github.com>
@iAmWillShepherd @billygriffin
Update docs/technical/rebase-flow.md
76d562c 
Co-Authored-By: billygriffin <5091167+billygriffin@users.noreply.github.com>
iAmWillShepherd and others added 2 commits May 1, 2019 12:06
@iAmWillShepherd @billygriffin
Update docs/technical/rebase-flow.md
28d4434 
Co-Authored-By: billygriffin <5091167+billygriffin@users.noreply.github.com>
@shiftkey
Apply suggestions from code review
5af0ffb 
Co-Authored-By: shiftkey <brendan@github.com>
PR Priority automation moved this from Review in progress to Awaiting Merge May 2, 2019
@iAmWillShepherd iAmWillShepherd merged commit 4e05e7c into development May 2, 2019
PR Priority automation moved this from Awaiting Merge to Done May 2, 2019
@iAmWillShepherd
Copy link
Contributor

Merged early and did not update branch since this is a docs change.

@iAmWillShepherd iAmWillShepherd deleted the more-rebase-docs branch May 2, 2019 21:37
@shiftkey shiftkey moved this from Beta - 2nd May to 1.7.0 release in Rebase Epic May 3, 2019
@shiftkey shiftkey moved this from 1.7.0 release to Beta - 9th May in Rebase Epic May 6, 2019
@nerdneha nerdneha removed this from Beta - 9th May in Rebase Epic May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billygriffin billygriffin billygriffin left review comments

@iAmWillShepherd iAmWillShepherd iAmWillShepherd approved these changes

Assignees

@iAmWillShepherd iAmWillShepherd

Labels
docs Issues and pull requests related to documentation work on the project ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
No open projects
PR Priority
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shiftkey @iAmWillShepherd @billygriffin