Windows title bar #775
Windows title bar #775
Conversation
鈽濓笍 something like 馃憞
@donokuda Food for thought, let's not tackle it in this PR though but let's play around with it next week. In this mock I dropped the differently colored sidebar section of the toolbar because I feel like it's getting to be a bit too much going on up there which is a shame because without the title bar it looks fabulous. |
Need that specificity
Automatic positioning of icons
|
This is ready for review |
| margin-top: calc(var(--win32-title-bar-height) * -1); | ||
| } | ||
| } | ||
| } |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -61,7 +53,7 @@ | |||
| display: inline-block; | |||
| position: relative; | |||
| width: 45px; | |||
| height: 29px; | |||
| height: calc(var(--win32-title-bar-height) - 1px); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -71,12 +63,15 @@ | |||
| box-shadow: none; | |||
| border-radius: 0; | |||
|
|
|||
| color: #fff; | |||
| color: #a0a0a0; | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
(This presumably fixes #702.) |
Indeed, updated PR body |
|
馃惃 |
Unfortunately one of the Chrome updates broke our inline title bar on Windows. I couldn't find any way of getting the title bar buttons to work short of removing
-webkit-app-region: dragfrom the toolbar.I would have loved to keep it inline but instead of spending time and fighting this now I think slapping a title bar on it is a reasonable way forward. It also makes life a little bit easier for us since all platform now have the same amount of horizontal space for the toolbar buttons (minus the app menu button on non-Darwin). This is how it looks currently (cropped to fit issue width)
Not the greatest looking title bar ever but we can work on that.
Future things we could explore here is moving the menu button up into the title bar or even exploding the menu into individual top level menu items with one button for each in the title bar but that's outside of the scope of this PR. Similar to how PS does it 馃憞
One downside of this is that our differently colored sidebar section of the toolbar feels less sparkly now. I'll put this on my list for things for me and @donokuda to chat about at the hack house.
TODO
Fixes #702