Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit app/test/fixtures results from VS Code project search #8224

Merged
merged 3 commits into from
Sep 10, 2019

Conversation

mislav
Copy link
Contributor

@mislav mislav commented Sep 6, 2019

When searching variables/method calls under this project in VS Code, there are often many results from under app/test/fixtures, but those results are rarely relevant or informative. This excludes that directory from project-wide search.

When searching variables/method calls under this project VS Code, there are often many results from under `app/test/fixtures`, but those results are rarely relevant or informative. This excludes that directory from project-wide search.
Copy link
Contributor

@kuychaco kuychaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 good call @mislav! I tried it out locally and I love it already 💖

@kuychaco kuychaco added the ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 6, 2019
@kuychaco kuychaco added this to Needs to be Prioritized in PR Priority via automation Sep 6, 2019
@kuychaco kuychaco moved this from Needs to be Prioritized to Review in progress in PR Priority Sep 6, 2019
@kuychaco kuychaco merged commit 46a9980 into development Sep 10, 2019
PR Priority automation moved this from Review in progress to Done Sep 10, 2019
@kuychaco kuychaco deleted the vscode-ignore-fixtures branch September 10, 2019 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants