Prevent application crash when spawn fails #8614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outofambit
previously approved these changes
Nov 14, 2019
Co-Authored-By: evelyn masso <outofambit@github.com>
outofambit
previously approved these changes
Nov 14, 2019
|
CI is failing here because we didn't update the lockfile with |
outofambit
approved these changes
Nov 14, 2019
Desktop 2.2.4 release
automation
moved this from Review In Progress
to PRs For Next Beta
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR bumps dugite to v1.87.3, a patch release containing desktop/dugite#381. The dugite bump is necessary in order for Desktop to be able to properly handle errors related to process spawning.
If the operating system prevented us from launching a processes due to resource exhaustion (EAGAIN), permissions problems (EACCES), or other problems
GitProcess.execandGitProcess.spawnwould throw an error due to the stdio streams on the launched child process not being available. This error would mask the actual, underlying error which would be emitted asynchronously and since we hadn't subscribed to theerrorhandler of the process yet (due to the masking exception) the exception would be raised as an unhandled exception and the app would crash.In addition to fixing this "unpreventable" crash this PR audits the places in Desktop where we assume that the
process.std*streams are always present and adds som extra debugging data for us to use instead of the genericspawn /Users/.../git: EAGAINerror thrown by Node.Release notes
Notes: [Fix] Prevent application crash when system is unable to launch Git