SAML re-authorization dialog #8910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tierninho
approved these changes
Jan 13, 2020
There was a problem hiding this comment.
Testing notes:
- Overall this works well and will hopefully help with some of the auth issues coming through 👍
- I can foresee some minor confusion with "authorize" and "continue" on the SSO page. We do not explicitly say you have to click "authorize", just "grant access". I think most will get it though. If the user clicks continue, we surface a similar warning but only in the console logs:
install.ts:27 fetchCommit: returned an error 'github/quality@de8bc7a12fc8208e9e21ff47777bee9e13905d26'
Error: Resource protected by organization SAML enforcement. You must grant your personal token access to this organization.
No strong feels on doing anything to change the current fix, just wanted to point it out.
kuychaco
approved these changes
Jan 14, 2020
There was a problem hiding this comment.
Code looks great! Thanks @niik ✨. And thanks @tierninho for testing 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This introduces special case handling of a particular set of access denied errors related to SAML and SSO. When a user is signed in but their token hasn't yet been authorized for a particular SAML organization fetches, pushes, and pulls will fail with a specific error message from the server informing the user that they need to re-authorize (sign out and back in again).
Screenshots
Before
After
Flow
Testing notes (requires membership in a SAML org)
4. Attempt to fetch, push, or pull a private repository owned by your SAML orgExpected result is a dialog that allows you to sign in again using the Web flow where you have the ability to authorize the SAML org.
Release notes
Notes: