-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fork] PR list call to action #8965
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working through this together @outofambit! ✨
This reverts commit dd4d6df.
Possible to outline the repro steps for this? I attempted to recreate this but ran into some blockers as the following are assumed to be true:
However, in your screenshot, it shows a PR badge. Where did it come from? |
@tierninho i added steps to the PR description! hopefully that helps, lmk if you have more questions! (the pr badge in the branch dropdown is displayed if a matching pr is found in the fork or its upstream) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things seem to be working great now ✅ after the latest round of changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @outofambit 🚀. Thanks for the thorough testing @tierninho ✨
this is a revisiting of #8936 and #8937
Description
Screenshots
Release notes
Notes: [Added] Link in Pull Request list to view the current pull request on GitHub
Testing notes
outofambit/desktop
to be merged intodesktop/desktop
)