Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly configure TERM env var to skirt around Git progress issue on Windows #9003

Merged
merged 2 commits into from
Jan 29, 2020

Conversation

niik
Copy link
Member

@niik niik commented Jan 29, 2020

On Windows we apparently have to explicitly set TERM to dumb for the is_terminal_dumb check to return true. See #8962

Description

On Windows we have to explicitly set it to 'dumb' for the is_terminal_dumb check to return true. See #8962 for the background

Screenshots

screen_shot_2020-01-29_at_11 37 08_am

Release notes

Notes: [Fixed] Inaccurate Git Progress parsing on Window

On Windows we apparently have to explicitly set it to 'dumb' for the is_terminal_dumb check to return true. See #8962
Copy link
Contributor

@kuychaco kuychaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and I tested on mac 👍. We'll test again after merged into the 2.3 release branch to verify on Windows.

Thanks @niik

@kuychaco kuychaco merged commit 8a05501 into releases/2.3.0 Jan 29, 2020
@kuychaco kuychaco deleted the dumb-dumber-2 branch January 29, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants