Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exempts known git auth errors from clone retry error handler #9777

Merged
merged 1 commit into from
May 13, 2020
Merged

exempts known git auth errors from clone retry error handler #9777

merged 1 commit into from
May 13, 2020

Conversation

outofambit
Copy link
Contributor

Closes #9776

Description

  • exempts known git auth errors from getting handled by the retry clone handler
  • reorders error handlers so that auth error handler is always checked first.

Release notes

Notes: [Fixed] Restore option to enter credentials for non-GitHub clone operations

@outofambit outofambit added this to Awaiting Review in Desktop 2.5.x releases May 12, 2020
tierninho
tierninho approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@tierninho tierninho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cloning private and public repos, both GitHub and non-Github are working as expected.

@manugd14
Copy link

How can I update my client with this changes?. Thanks.

@outofambit outofambit merged commit 7d3d32e into development May 13, 2020
Desktop 2.5.x releases automation moved this from Awaiting Review to PRs For Next Beta May 13, 2020
@outofambit outofambit deleted the bugfix/gitlab-auth-loop branch May 13, 2020 16:19
@shiftkey shiftkey mentioned this pull request Jun 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niik niik niik approved these changes

@tierninho tierninho tierninho approved these changes

@rafeca rafeca Awaiting requested review from rafeca

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Desktop 2.5.x releases
PRs For Next Beta
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Authentification error, infinite retry loop.
4 participants
@outofambit @manugd14 @niik @tierninho