Center tags text vertically in history view #9785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruggi99
reviewed
May 13, 2020
Comment on lines
52
to
+53
| height: 16px; | ||
| line-height: 16px; |
There was a problem hiding this comment.
Suggested change
| height: 16px; | |
| line-height: 16px; | |
| height: 18px; | |
| line-height: 18px; |
I think it's better
tierninho
approved these changes
May 13, 2020
|
This new tags feature is amazing. THANK YOU!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the vertical alignment of tag names in the history view, which used to be 1px too low.
Slack reference: https://github.slack.com/archives/C9E33R811/p1589311861095500
Screenshots
Before:
Now:
Release notes
Notes: [Improved] Vertically align tag names in history view