Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-verify arg to fetchTagsToPush command to avoid executing unwanted hooks #9793

Merged
merged 1 commit into from
May 14, 2020

Conversation

rafeca
Copy link
Contributor

@rafeca rafeca commented May 14, 2020

Closes #9787

Description

This PR adds the --no-verify CLI argument to the command that checks which tags that need to be pushed. In this case we don't need to run any hook (and in fact running hooks can have unintended side-effects) so we need to tell git to not run them.

Release notes

Notes: [Fixed] Do not execute push hooks when checking for tags to push

@rafeca rafeca requested review from niik and outofambit May 14, 2020 10:06
@rafeca rafeca added this to In Progress PRs in Desktop 2.5.x releases via automation May 14, 2020
Copy link
Contributor

@outofambit outofambit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@outofambit outofambit merged commit 73b71da into development May 14, 2020
Desktop 2.5.x releases automation moved this from In Progress PRs to PRs For Next Beta May 14, 2020
@outofambit outofambit deleted the avoid-push-hooks branch May 14, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Desktop 2.5.x releases
PRs For Next Beta
Development

Successfully merging this pull request may close these issues.

Client triggers pre-push hook when coming to foreground
3 participants