fix: missing require to fs.rmSync.
#538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tidy-dev
approved these changes
Aug 2, 2023
|
Hmm.. I see the checks are not running. @richardo2016 would you mind merging the main branch in to get a fresh commit to trigger the ci (and just update since this pr got a little stale, sorry about that) 🙏 ? |
No problem, I'll try merge main branch to see if the checks running. |
tidy-dev
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this PR aims to solve this issue:
#523
I was actually surprised by this issue. It is a very obvious and easily fixable error. Why didn't any official member handle it before? Was it simply because the path that used rmSync was hardly triggered? But due to another issue with https_proxy, this path can be easily triggered on Windows.