Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grunt-release support #23

Merged
merged 3 commits into from
Apr 10, 2014

Conversation

patcon
Copy link
Collaborator

@patcon patcon commented Mar 30, 2014

We have it for the generated scripts, but not for this generator. Makes it dead-easy to release :)

@patcon
Copy link
Collaborator Author

patcon commented Mar 30, 2014

Heh. Don't even know how to release without it, so seemed fitting to merge this first

@desmondmorris
Copy link
Owner

Yah thats cool. Per Travis, it looks like grunt-release does not play nice with node 0.8. We could always pull 0.8 support. Thoughts @patcon?

I usually just update the version by hand, create a tag then run npm publish

@patcon
Copy link
Collaborator Author

patcon commented Apr 1, 2014

Totally true that it can be easy, but nice to standardize. So I guess we could either drop 0.8 support or use --production on travis so it doesn't try to install the dev deps? Your call, but I think it's worth adding somehow :)

@patcon
Copy link
Collaborator Author

patcon commented Apr 1, 2014

WTF was I thinking..? :/

OK, removing 0.8 for now but it's your call. We can see what the grunt-release maintainer says on that linked issue

desmondmorris added a commit that referenced this pull request Apr 10, 2014
@desmondmorris desmondmorris merged commit 32a3373 into desmondmorris:master Apr 10, 2014
@patcon patcon deleted the grunt-release-support branch April 10, 2014 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants