Update test template to use hubot-mock-adapter #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haven't tested this PR, but I like it that adapter :) You were open to the idea of treating hubot-mock-adapter as something quasi-official, right @technicalpickles? |
|
I was actually all for hubot-mock-adapter, but I'm going to try out hubot-test-helper first (linked here by atmos: hubotio/hubot#714) |
|
@patcon ah ok, let me know what you think of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings!
The purpose of this pull request is to update the test template to utilize the fancy hubot-mock-adapter, which is a great way to thoroughly test your Hubot scripts! While I personally find the
hubot-mock-adapterto be super useful, it takes a decent amount of boilerplate to get setup, so it's an ideal addition to the generator!I also got sick of manually deleting the
test/tempdirectory when re-running the tests, so I also added the grunt-contrib-clean plugin to thetesttask chain.As always, let me know if you have any comments, questions or concerns! Thanks 😄