Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to specify a full path #232

Merged
merged 1 commit into from
Jun 13, 2017
Merged

Conversation

gvnn
Copy link

@gvnn gvnn commented Jun 6, 2017

If a full url is specified the library shouldn't add a .json at the end. The use case for this is using the same client also for gnip (which doesn't have .json at the end of path)

@DevGorilla
Copy link

DevGorilla commented Jun 6, 2017

I just submitted a similar PR. This is a better (and necessary) solution.

@DevGorilla DevGorilla mentioned this pull request Jun 6, 2017
@gvnn
Copy link
Author

gvnn commented Jun 7, 2017

hey @DevGorilla I haven't seen your PR sorry about that... I'm not fussy on the solution as long as I can specify a whole path 😉

@DevGorilla
Copy link

@gvnn Agreed. .JSON screws up pagination in the ads api

@DevGorilla
Copy link

@desmondmorris Is this a reasonable change for you to integrate?

@desmondmorris
Copy link
Owner

This looks good, thanks @gvnn @DevGorilla

@desmondmorris desmondmorris merged commit 458dde9 into desmondmorris:master Jun 13, 2017
@gvnn
Copy link
Author

gvnn commented Jun 13, 2017

Thanks @desmondmorris... can I ask one little favour? would be possible to have an update of the package.json and publish an update? No stress, whenever you've got time. Thanks again!

@desmondmorris
Copy link
Owner

@gvnn done!

@gvnn
Copy link
Author

gvnn commented Jun 13, 2017

Thanks man!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants