Wrong JSON tags inside MsgSaveProfile

[RiccardoM]

Bug description

From Calvin:

when signing a save profile tx, profile picture and cover picture fields are required. it can be an empty string but cant be omitted. while for name and bio, the fields can be omitted but cannot be an empty string.

This is because the profile_picture and cover_picture fields have custom attributes and do not include the omitempty clause that other fields have by default.

Expected behavior

All the fields should have the same behavior (ie. should be omittable).

[calvinkei]

Example of failing tx

{
    "typeUrl": "/desmos.profiles.v1beta1.MsgSaveProfile",
    "value": {
        "dtag": "testing",
        "creator": "desmos1szeh3fcef020u0uq8ynl28daznyyj7q68wgr3m"
    }
}

Example of successful tx

{
    "typeUrl": "/desmos.profiles.v1beta1.MsgSaveProfile",
    "value": {
        "dtag": "testing"
        "creator": "desmos1szeh3fcef020u0uq8ynl28daznyyj7q68wgr3m",
        "profilePicture": "",
        "coverPicture": ""
    }
}

Steps to Reproduce

1. Create a new account on Forbole X
2. Create a new profile for the new account
3. Only input the dtag field and send transaction
4. You should see an error Broadcasting transaction failed with code 4 (codespace: sdk). Log: signature verification failed; please verify account number (399), sequence (0) and chain-id (desmos-mainnet): unauthorized
5. The transaction will succeed if you include a profilePicture and coverPicture

[RiccardoM]

@calvinkei How did you generate those JSON structs? Did you use Protobuf or did you do it by hand? I'm curios where you got the profilePicture and coverPicture names specifically since they should be profile_picture and cover_picture respectively

[calvinkei]

@RiccardoM this is the format used in cosmjs. they replace @type by typeUrl and snake case by camel case. it will be converted to the correct format before signing. not sure why they do that though

[leobragaz]

closed by #655