Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Ledger while signing values #1059

Merged
merged 3 commits into from
Dec 28, 2022

Conversation

RiccardoM
Copy link
Contributor

@RiccardoM RiccardoM commented Dec 26, 2022

Description

This PR adds the Ledger support inside the sign command by wrapping the value into a transaction memo before signing it.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@RiccardoM RiccardoM requested a review from a team as a code owner December 26, 2022 01:26
@github-actions github-actions bot added x/CLI x/profiles Module that allows to create and manage decentralized social profiles x/relationships labels Dec 26, 2022
@codecov
Copy link

codecov bot commented Dec 26, 2022

Codecov Report

Base: 80.40% // Head: 80.24% // Decreases project coverage by -0.15% ⚠️

Coverage data is based on head (45e6d46) compared to base (073b6ce).
Patch coverage: 44.44% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1059      +/-   ##
==========================================
- Coverage   80.40%   80.24%   -0.16%     
==========================================
  Files         176      176              
  Lines       15390    15444      +54     
==========================================
+ Hits        12374    12393      +19     
- Misses       2476     2509      +33     
- Partials      540      542       +2     
Impacted Files Coverage Δ
x/profiles/keeper/keeper.go 91.72% <ø> (ø)
x/profiles/keeper/relay_app_links.go 86.88% <ø> (ø)
x/profiles/keeper/relay_chain_links.go 86.36% <ø> (ø)
x/profiles/legacy/v4/store.go 61.53% <ø> (ø)
x/profiles/types/models_chain_links.go 74.28% <ø> (ø)
x/profiles/types/models_packets.go 94.28% <ø> (ø)
x/profiles/types/msgs_app_links.go 87.32% <ø> (ø)
x/relationships/legacy/v1/store.go 57.14% <ø> (ø)
app/desmos/cmd/sign/sign.go 47.91% <43.54%> (-16.37%) ⬇️
app/desmos/cmd/chainlink/create_json.go 57.14% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@dadamu dadamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RiccardoM RiccardoM added the automerge Automatically merge PR once all prerequisites pass label Dec 28, 2022
@mergify mergify bot merged commit 17cc20e into master Dec 28, 2022
@mergify mergify bot deleted the riccardom/support-ledger-inside-sign branch December 28, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass x/CLI x/profiles Module that allows to create and manage decentralized social profiles x/relationships
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants